[Onboarding] fix skipped api key tests #195911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
added
backport:prev-minor
TattdCodeMonkey
approved these changes
Oct 11, 2024
|
@elasticmachine merge upstream |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7136[❌] x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts: 0/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7144[✅] x-pack/test_serverless/api_integration/test_suites/search/config.feature_flags.ts: 15/15 tests passed. |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7149[✅] x-pack/test_serverless/api_integration/test_suites/search/config.feature_flags.ts: 25/25 tests passed. |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
## Summary Failing due to api keys could not be generated as keys were created previously and were purged in session. Fix is to move the deletion to run at beforeEach rather than the start. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 708bf08)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding] fix skipped api key tests (#195911)](#195911) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe McElroy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T18:50:33Z","message":"[Onboarding] fix skipped api key tests (#195911)\n\n## Summary\r\n\r\nFailing due to api keys could not be generated as keys were created\r\npreviously and were purged in session. Fix is to move the deletion to\r\nrun at beforeEach rather than the start.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"708bf08f91502a501f9744a4a0b35c6cbdeb9990","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[Onboarding] fix skipped api key tests","number":195911,"url":"https://github.com/elastic/kibana/pull/195911","mergeCommit":{"message":"[Onboarding] fix skipped api key tests (#195911)\n\n## Summary\r\n\r\nFailing due to api keys could not be generated as keys were created\r\npreviously and were purged in session. Fix is to move the deletion to\r\nrun at beforeEach rather than the start.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"708bf08f91502a501f9744a4a0b35c6cbdeb9990"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195911","number":195911,"mergeCommit":{"message":"[Onboarding] fix skipped api key tests (#195911)\n\n## Summary\r\n\r\nFailing due to api keys could not be generated as keys were created\r\npreviously and were purged in session. Fix is to move the deletion to\r\nrun at beforeEach rather than the start.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"708bf08f91502a501f9744a4a0b35c6cbdeb9990"}}]}] BACKPORT--> Co-authored-by: Joe McElroy <[email protected]>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Oct 17, 2024
## Summary Failing due to api keys could not be generated as keys were created previously and were purged in session. Fix is to move the deletion to run at beforeEach rather than the start. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Failing due to api keys could not be generated as keys were created previously and were purged in session. Fix is to move the deletion to run at beforeEach rather than the start.